Replaces #7390, #7391, & #7400 #7401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danforbes
requested review from
avkos,
jdevcs,
luu-alex,
Muhammad-Altabba and
krzysu
as code owners
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 0ac899a | Previous: 5437fbc | Ratio |
|---|---|---|---|
processingTx |
20444 ops/sec (±8.01%) |
23185 ops/sec (±7.07%) |
1.13 |
processingContractDeploy |
40544 ops/sec (±5.68%) |
39369 ops/sec (±7.85%) |
0.97 |
processingContractMethodSend |
15016 ops/sec (±9.64%) |
16560 ops/sec (±6.83%) |
1.10 |
processingContractMethodCall |
28128 ops/sec (±6.78%) |
27873 ops/sec (±6.86%) |
0.99 |
abiEncode |
43860 ops/sec (±7.19%) |
44185 ops/sec (±8.48%) |
1.01 |
abiDecode |
29322 ops/sec (±8.41%) |
31247 ops/sec (±7.26%) |
1.07 |
sign |
1532 ops/sec (±0.82%) |
1579 ops/sec (±0.89%) |
1.03 |
verify |
362 ops/sec (±2.82%) |
371 ops/sec (±0.50%) |
1.02 |
This comment was automatically generated by workflow using github-action-benchmark.
krzysu
approved these changes
Nov 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7401 +/- ##
=======================================
Coverage 94.51% 94.51%
=======================================
Files 218 218
Lines 8557 8557
Branches 2364 2364
=======================================
Hits 8088 8088
Misses 469 469
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix various small typos that were pointed out by community members. Replaces #7390, #7391, & #7400.